Indicate to ember-cli that this addon should be "before" redis #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin (if present). Because both plugins implement the build hook, this will make it so that s3 runs before redis, and thus, that the assets are uploaded before the HTML that points to them.
| @@ -50,6 +50,7 @@ | |||
| "minimatch": "^2.0.4" | |||
| }, | |||
| "ember-addon": { | |||
| "configPath": "tests/dummy/config" | |||
| "configPath": "tests/dummy/config", | |||
| "before": "ember-cli-deploy-redis" | |||
There was a problem hiding this comment.
@lukemelia This does feel a little weird in that it fixes it for this example but if a user is using a different plugin uploading the index.html somewhere else, they have the same problem. The "advanced config" will really be the true solution to this I think where a user can specify in config the order that plugins should run. But for now, this is a good middle ground.
There was a problem hiding this comment.
Agree re: the advanced config. But I think we can add these order hints as necessary to help make plugins work together out of the box.
achambers
pushed a commit
that referenced
this pull request
May 29, 2015
Indicate to ember-cli that this addon should be "before" redis
|
Thanks @lukemelia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicate to ember-cli that this addon should be "before" the redis plugin (if present).
Because both plugins implement the build hook, this will make it so that s3 runs before redis, and thus, that the assets are uploaded before the HTML that points to them.