added config to include hidden folders in the S3 upload #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,8 +56,9 @@ module.exports = { | |||
| var manifestPath = this.readConfig('manifestPath'); | |||
| var cacheControl = this.readConfig('cacheControl'); | |||
| var expires = this.readConfig('expires'); | |||
| var dotFolders = this.readConfig('dotFolders'); | |||
There was a problem hiding this comment.
Very very minor, OCD based, nitpick, but mind lining that = sign up for us please @habdelra ? ;)
|
Thanks @habdelra . Great stuff. Mind making the tests pass please? Happy to merge it in then. |
|
thanks @habdelra ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed & Why
I added a config property so that we can upload files in hidden folders. We're adding apple pay to our application and it requires a folder called
.well-known/to exist. It looks like you need to tell theminimatchnpm module that you want to include hidden folders as part of the matching criteria, otherwise it will ignore files in folders that are prefixed by.