Adds support for batching requests to S3 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Can you take a look as well @achambers? Before we merge, it would great if you can clean up the commit history @tomlagier. |
This is primarily useful to avoid flooding fake-s3 with network requests. 1) Added "batchSize" configuration option, defaulted to 0 2) Added code path to s3._putObjects to handle batching requests if batchSize option is set 3) Added appropriate tests 4) Updated the readme
tomlagier
force-pushed
the
issues/78-batching-file-uploads
branch
from
fadf290
to
dd6466d
Compare
|
Squashed the commits, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed & Why
This is primarily useful to avoid flooding fake-s3 with network requests.
Related issues
See #78
PR Checklist
People
@lukemelia