Fix defaultMimeType option binding #94
Conversation
| @@ -61,6 +61,7 @@ module.exports = { | |||
| var dotFolders = this.readConfig('dotFolders'); | |||
| var serverSideEncryption = this.readConfig('serverSideEncryption'); | |||
| var batchSize = this.readConfig('batchSize'); | |||
| var defaultMimeType = this.readConfig('defaultMimeType'); | |||
There was a problem hiding this comment.
Even though this is specified in the README we don't have an actual default for it in the defaultConfig above. Worth adding it there?
There was a problem hiding this comment.
@achambers What do you think about adding the default as simply application/octet-stream? because I guess thats the only reasonable default I can think of. Have you got any other ideas?
There was a problem hiding this comment.
@wytlytningNZ Yep, exactly. That's what the README says it is. So, what I meant was, would you mind adding that default in the defaultConfig prop as a part of this PR?
There was a problem hiding this comment.
@achambers sure thing. Just added it now.
Interestingly though, application/octet-stream is already set to the default by the mime module if no default is supplied, but I guess its better be to more explicit.
There was a problem hiding this comment.
but I guess its better be to more explicit.
Yep. The principle of least surprise and all that :)
|
Released as v1.1.0 Thanks @wytlytningNZ |
What Changed & Why
defaultMimeType field is ignored in the ember-cli-deploy options, as it isn't passed into the s3 options correctly. This pull request fixes this binding
Related issues
Here is the issue: #93