Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass useEmberModule option to plugins #682

Closed

Conversation

patocallaghan
Copy link

@patocallaghan patocallaghan commented Mar 15, 2021

I'm just working my way through various things here and pushing up what I have so far to help get myself unblocked.

  1. It appears we require a new release of ember-cli-babel with Update babel plugins and pin to @babel/runtime@7.12.8 emberjs/ember-cli-babel#385 (as it has an upgrade of babel-plugin-ember-modules-api-polyfill) because it looks like the imports mismatch in tests (imports _ember2 but uses _ember) instead. We require an upgrade of
    image

  2. Colocated components don't appear to be transformed from using the global Ember
    image

@@ -76,7 +76,7 @@
"ember-maybe-import-regenerator": "^0.1.6",
"ember-qunit": "^4.6.0",
"ember-resolver": "^8.0.0",
"ember-source": "~3.25.0",
"ember-source": "~3.27.0-alpha.2",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've upgraded here and also added the ember key below just so I can test locally. I'll remove these before merging

@rwjblue
Copy link
Member

rwjblue commented Mar 16, 2021

I was chatting with @pzuraq about this yesterday, I think we probably want to update the babel-plugin-htmlbars-inline-precompile to just leverage the "real modules" when we are operating on Ember 3.27+. I believe that @pzuraq is working on a PR that finishes out emberjs/ember.js#16529.

@patocallaghan
Copy link
Author

@rwjblue thanks! so I can close this PR?

@rwjblue
Copy link
Member

rwjblue commented Mar 16, 2021

Hmm, no I don't think so. I think we'll likely still need some change here, but instead of having that babel plugin inject the 'ember' module import we'd just have it do the other's.

@rwjblue
Copy link
Member

rwjblue commented Mar 16, 2021

Basically, this option:

https://github.com/ember-cli/babel-plugin-htmlbars-inline-precompile/blob/e2ba193dfa6f9b01ec41b06530ffe35ad41c9e31/index.js#L174-L175

We want to ensure that we pass false when using Ember 3.27+.

@patocallaghan
Copy link
Author

patocallaghan commented Mar 17, 2021

@rwjblue @pzuraq I assume this PR can be closed as #683 is the correct approach now?

@rwjblue rwjblue closed this Mar 18, 2021
@rwjblue
Copy link
Member

rwjblue commented Mar 18, 2021

Yep! Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants