Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use simplified babel plugin on ember 3.27+ and drop unsupported node versions #724

Merged
merged 9 commits into from
Oct 14, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jul 14, 2021

node-tests/utils_test.js Outdated Show resolved Hide resolved
Co-authored-by: Matt McManus <matt@mcmanus.io>
@ef4 ef4 marked this pull request as ready for review October 14, 2021 00:40
@ef4
Copy link
Contributor Author

ef4 commented Oct 14, 2021

This is now ready to go:

  • it uses the new simplified babel-plugin-ember-template-compilation on ember 3.27+
  • it still supports the same range of older ember versions as before, using babel-plugin-htmlbars-inline-precompile
  • we dropped node < 12
  • I upgraded the test setup dependencies enough to get tests passing under latest canary
  • since ember 4 drops "legacy " AST plugin support, I removed those tests.
  • this includes a full regeneration of the yarn.lock, so merging it should close the backlog of dependabot PRs.
  • it seems that the compiled output of decorators was hard-coded into two tests and changed, so I had to change them to follow. As far as I can tell this is benign.

@ef4 ef4 merged commit 2e94551 into master Oct 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the inline-hbs-reform branch October 14, 2021 02:37
@ef4 ef4 added the breaking label Oct 14, 2021
@ef4 ef4 changed the title Inline HBS reform Use simplified babel plugin on ember 3.27+ and drop unsupported node versions Oct 14, 2021
@NullVoxPopuli
Copy link

what's the simplified babel plugin do? (tldr?)

@ef4
Copy link
Contributor Author

ef4 commented Oct 18, 2021

It implements inline template compilation and only that. And it does it in a way that composes with other Babel plugins that want to emit inline templates.

@mattmcmanus
Copy link
Contributor

@NullVoxPopuli You can read the write up in the linked PR for a more detailed overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants