-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use simplified babel plugin on ember 3.27+ and drop unsupported node versions #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmcmanus
suggested changes
Jul 15, 2021
Co-authored-by: Matt McManus <matt@mcmanus.io>
ef4
force-pushed
the
inline-hbs-reform
branch
from
October 14, 2021 01:05
bd4f481
to
b87219a
Compare
ef4
force-pushed
the
inline-hbs-reform
branch
from
October 14, 2021 02:21
5ad3486
to
b38529f
Compare
This is now ready to go:
|
ef4
changed the title
Inline HBS reform
Use simplified babel plugin on ember 3.27+ and drop unsupported node versions
Oct 14, 2021
what's the simplified babel plugin do? (tldr?) |
It implements inline template compilation and only that. And it does it in a way that composes with other Babel plugins that want to emit inline templates. |
@NullVoxPopuli You can read the write up in the linked PR for a more detailed overview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accompanies ember-cli/babel-plugin-htmlbars-inline-precompile#462.