-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to force baseURL #24
Conversation
Do not override EMBER_CLI_INJECT_LIVE_RELOAD_BASEURL if already defined. This allows an independent development server (not the express one bundled with ember-cli) to serve several apps while being live-reloaded.
Was going to do something similar. This is actually pretty handy in some weird contexts, such as ember-cli-deploy's lightning fast development method. When the template is pulled in via redis and injected into a local rails app, the path to livereload points to an asset relative to the rails app, where if the URL is http://localhost:4200/ember-cli-live-reload.js it works fine. The current plugin doesn't allow this change. |
👍 Happy to see someone else with the same use case. |
@jbescoyez : @typeoneerror just pointed me at this one. I was working on something similar with @elucid a while ago but never got to finish the PR Definitely a use case we encountered with ember-cli-deploy and development workflows |
@rwjblue Do you think this one could be merged? |
One thing I'd like to mention: the other options here can be configured via |
Updated in order to allow configuration through |
Following @elucid suggestion, I made it available through @rwjblue Do see any objection to merge this PR? Tnx. |
Published as 1.4.0 |
[ENHANCEMENT] Make `EMBER_CLI_INJECT_LIVE_RELOAD_BASEURL` configurable See: rwjblue/ember-cli-inject-live-reload#24
[ENHANCEMENT] Make `EMBER_CLI_INJECT_LIVE_RELOAD_BASEURL` configurable See: rwjblue/ember-cli-inject-live-reload#24
💥 thanks! |
💪 this is awesome! |
Does not override EMBER_CLI_INJECT_LIVE_RELOAD_BASEURL if already defined.
This allows an independent development server (not the express one bundled with ember-cli) to serve several apps while being live-reloaded.