Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to force baseURL #24

Merged
merged 2 commits into from
Dec 8, 2015
Merged

Allow to force baseURL #24

merged 2 commits into from
Dec 8, 2015

Conversation

jbescoyez
Copy link
Contributor

Does not override EMBER_CLI_INJECT_LIVE_RELOAD_BASEURL if already defined.

This allows an independent development server (not the express one bundled with ember-cli) to serve several apps while being live-reloaded.

Do not override EMBER_CLI_INJECT_LIVE_RELOAD_BASEURL if already defined.

This allows an independent development server (not the express one bundled with ember-cli)  to serve several apps while being live-reloaded.
@typeoneerror
Copy link

Was going to do something similar. This is actually pretty handy in some weird contexts, such as ember-cli-deploy's lightning fast development method. When the template is pulled in via redis and injected into a local rails app, the path to livereload points to an asset relative to the rails app, where if the URL is http://localhost:4200/ember-cli-live-reload.js it works fine. The current plugin doesn't allow this change.

@jbescoyez
Copy link
Contributor Author

👍 Happy to see someone else with the same use case.

@ghedamat
Copy link

@jbescoyez : @typeoneerror just pointed me at this one.

I was working on something similar with @elucid a while ago but never got to finish the PR

ghedamat@10f19d5

Definitely a use case we encountered with ember-cli-deploy and development workflows

@jbescoyez
Copy link
Contributor Author

@rwjblue Do you think this one could be merged?

@elucid
Copy link

elucid commented Nov 16, 2015

One thing I'd like to mention: the other options here can be configured via .ember-cli, whereas with the above solution, you must use an environment variable. I would prefer to have something where this can be set in .ember-cli.

@jbescoyez
Copy link
Contributor Author

Updated in order to allow configuration through .ember-cli. Related to: ember-cli/ember-cli#5132

@jbescoyez
Copy link
Contributor Author

Following @elucid suggestion, I made it available through ember-cli.
@stefanpenner just approved my PR in ember-cli: ember-cli/ember-cli#5132 .
The last step is to make it happen here.

@rwjblue Do see any objection to merge this PR? Tnx.

rwjblue added a commit that referenced this pull request Dec 8, 2015
@rwjblue rwjblue merged commit d26ca2e into ember-cli:master Dec 8, 2015
@rwjblue
Copy link
Member

rwjblue commented Dec 8, 2015

Published as 1.4.0

homu referenced this pull request in ember-cli/ember-cli Dec 8, 2015
[ENHANCEMENT] Make `EMBER_CLI_INJECT_LIVE_RELOAD_BASEURL` configurable

See: rwjblue/ember-cli-inject-live-reload#24
homu referenced this pull request in ember-cli/ember-cli Dec 9, 2015
[ENHANCEMENT] Make `EMBER_CLI_INJECT_LIVE_RELOAD_BASEURL` configurable

See: rwjblue/ember-cli-inject-live-reload#24
@ghedamat
Copy link

💥 thanks!

@elucid
Copy link

elucid commented Dec 11, 2015

💪 this is awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants