This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Fix testing root element styles not working #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2015 12:21
The CSS provided by mocha differs from qunit's so absolute positioning doesn't work.
If no options are provided for this addon, the additional CSS isn't appended to test-support CSS file. Default options to empty object so the conditional passes.
| @@ -42,7 +42,7 @@ module.exports = { | |||
| 'vendor/ember-cli-mocha/test-loader.js' | |||
| ]; | |||
|
|
|||
| var addonOptions = app.options['ember-cli-mocha']; | |||
| var addonOptions = app.options['ember-cli-mocha'] || {}; | |||
| if (addonOptions && !addonOptions.disableContainerStyles) { | |||
There was a problem hiding this comment.
Not sure why the initialization to {} is needed. Won't the first check for the truthiness of addonOptions cover the use case in which the option doesn't exist?
There was a problem hiding this comment.
Scratch my comment above - I re-read the conditional and see that we need this by default. Sorry!
dgeb
added a commit
that referenced
this pull request
Apr 4, 2015
Fix testing root element styles not working
|
Thanks @Soliah! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the testing element wasn't styled properly in the browser. Looks like the CSS isn't added if no options are configured for the addon. Additionally it looks like the positioning of the element needs to be fixed rather than absolute like with qunit.