Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Allow generation of a component integration test. #57

Merged
merged 1 commit into from
Jun 19, 2015
Merged

Allow generation of a component integration test. #57

merged 1 commit into from
Jun 19, 2015

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Jun 17, 2015

Component integration tests are great, but they are difficult to figure out how to generate by default.

I had a few goals with this new blueprint:

  • do not affect default behavior for component test generation
  • allow having both unit and integration tests for a component
  • automatically require an inline template compiler

blimmer
blimmer reviewed Jun 17, 2015
View reviewed changes
blueprints/component-test/files/tests/__testfolder__/__path__/__test__.js
},
function() {
it('renders', function() {
<%= defaultTest %>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love that this information is now in index.js, but lodash templating is very simple and produces extremely ugly templates and output when using their if statement.

None of the ember-cli templates make use of the <% if (foo) { %> style templates, I'm assuming because of the bad readability and ugly output.

@blimmer blimmer changed the title Allow generation of a component integration test. [WIP] Allow generation of a component integration test. Jun 17, 2015
@blimmer blimmer force-pushed the component-integration-test-blueprint branch from 7300884 to f68f875 Compare June 18, 2015 13:20
@blimmer blimmer changed the title [WIP] Allow generation of a component integration test. Allow generation of a component integration test. Jun 18, 2015
@blimmer
Copy link
Contributor Author

blimmer commented Jun 18, 2015

@rwjblue the requested improvements have been made and tested with a test Ember app.

blimmer
blimmer reviewed Jun 18, 2015
View reviewed changes
package.json
@@ -28,7 +28,7 @@
},
"homepage": "https://github.com/switchfly/ember-cli-mocha",
"dependencies": {
"broccoli-jshint": "^0.5.3"
"broccoli-jshint": "^0.5.6"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need at least this version for JSHint to not complain about ES6 template literals.

@pangratz
Copy link

@blimmer LGTM!

@blimmer
Copy link
Contributor Author

blimmer commented Jun 19, 2015

@dgeb what do you think?

@dgeb
Copy link
Member

dgeb commented Jun 19, 2015

@blimmer this looks good to me as well.

@rwjblue what do you think? Is this sufficiently consistent with the qunit equivalent?

@blimmer
Copy link
Contributor Author

blimmer commented Jun 19, 2015

AFAIK, there's no equivalent yet in qunit (current blueprint). I did this PR because I don't use QUnit, but I could have a go at a PR for ember-cli to match this behavior.

@dgeb
Copy link
Member

dgeb commented Jun 19, 2015

@blimmer gotcha. I've been trying for parity between the two libs, since I don't want them to fork in different directions that can't be reconciled. So far, we've let ember-cli lead the way.

If you're up for a PR to ember-cli itself, that would be great. That would ensure a consistent strategy. 👍

@rwjblue I'm fine merging this whenever you are, with the understanding that we may need to change course to follow ember-cli later.

@rwjblue
Copy link
Member

rwjblue commented Jun 19, 2015

I'm perfectly happy exploring here and re-aligning with ember-cli once this same sort of update lands in ember-cli.

@blimmer - If you don't mind, I'd love a PR to ember-cli itself...

rwjblue added a commit that referenced this pull request Jun 19, 2015
@rwjblue
Merge pull request #57 from blimmer/component-integration-test-blueprint
1a56f36 
Allow generation of a component integration test.
@rwjblue rwjblue merged commit 1a56f36 into ember-cli:master Jun 19, 2015
@blimmer
Copy link
Contributor Author

blimmer commented Jun 19, 2015

@rwjblue I'll try to get a PR to ember-cli this weekend! Thank you all for your feedback. I think this feature would be very useful.

@dgeb
Copy link
Member

dgeb commented Jun 19, 2015

@blimmer thanks in advance!

Just published this in ember-cli-mocha v0.8.0 (along with a new ember-mocha v0.8.0 as well).

@blimmer blimmer deleted the component-integration-test-blueprint branch June 19, 2015 17:12
@pangratz
Copy link

@blimmer just a head up, there is already PR of this kind in ember-cli: ember-cli/ember-cli#4272

@blimmer blimmer mentioned this pull request Jun 20, 2015
Merged
@pangratz pangratz mentioned this pull request Aug 17, 2015
Closed
Turbo87 pushed a commit that referenced this pull request Oct 17, 2018
@dependabot @Turbo87
Bump ember-cli-inject-live-reload from 1.8.2 to 2.0.1 (#290)
648f73c 
Bumps [ember-cli-inject-live-reload](https://github.com/rwjblue/ember-cli-inject-live-reload) from 1.8.2 to 2.0.1.
<details>
<summary>Changelog</summary>

*Sourced from [ember-cli-inject-live-reload's changelog](https://github.com/ember-cli/ember-cli-inject-live-reload/blob/master/CHANGELOG.md).*

> ## v2.0.1 (2018-10-15)
> 
> #### 🐛 Bug Fix
> * [#66](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/66) Update minimum ember-cli version for scoped path ([[**rwjblue**](https://github.com/rwjblue)](https://github.com/rwjblue))
> * [#65](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/65) fix: syntax error in `dynamicScript` ([[**buschtoens**](https://github.com/buschtoens)](https://github.com/buschtoens))
> 
> #### Committers: 2
> - Jan Buschtöns ([[**buschtoens**](https://github.com/buschtoens)](https://github.com/buschtoens))
> - Robert Jackson ([[**rwjblue**](https://github.com/rwjblue)](https://github.com/rwjblue))
> 
> ## v2.0.0 (2018-10-15)
> 
> #### 💥 Breaking Change
> * [#60](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/60) Drop support for Node 4 ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### Committers: 1
> - Tobias Bieniek ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> ## v1.10.1 (2018-10-13)
> 
> #### 🚀 Enhancement
> * [#59](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/59) package.json: Declare Node.js version requirements. ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### 🐛 Bug Fix
> * [#58](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/58) Run test suite on TravisCI and fix Node 4 compatibility. ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### 🏠 Internal
> * [#57](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/57) Add linting via ESLint. ([[**rwjblue**](https://github.com/rwjblue)](https://github.com/rwjblue))
> 
> #### Committers: 2
> - Robert Jackson ([rwjblue](https://github.com/rwjblue))
> - Tobias Bieniek ([Turbo87](https://github.com/Turbo87))
> 
> 
> ## v1.10.0 (2018-10-13)
> 
> #### 🐛 Bug Fix
> * [#55](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/55) Pass path as argument to livereload.js ([[**SparshithNR**](https://github.com/SparshithNR)](https://github.com/SparshithNR))
> 
> #### 🏠 Internal
> * [#54](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/54) Refactoring and Tests ([[**SparshithNR**](https://github.com/SparshithNR)](https://github.com/SparshithNR))
> 
> #### Committers: 1
> - SparshithNRai ([[**SparshithNR**](https://github.com/SparshithNR)](https://github.com/SparshithNR))
</details>
<details>
<summary>Commits</summary>

- [`6177d46`](ember-cli/ember-cli-inject-live-reload@6177d46) 2.0.1
- [`f921618`](ember-cli/ember-cli-inject-live-reload@f921618) Add v2.0.1 to CHANGELOG.
- [`09f1525`](ember-cli/ember-cli-inject-live-reload@09f1525) Merge pull request [#66](https://github-redirect.dependabot.com/rwjblue/ember-cli-inject-live-reload/issues/66) from ember-cli/require-ember-cli-3-5-1
- [`ace5a8d`](ember-cli/ember-cli-inject-live-reload@ace5a8d) Update minimum ember-cli version for scoped path
- [`2e279ff`](ember-cli/ember-cli-inject-live-reload@2e279ff) Merge pull request [#65](https://github-redirect.dependabot.com/rwjblue/ember-cli-inject-live-reload/issues/65) from buschtoens/patch-1
- [`a5f3062`](ember-cli/ember-cli-inject-live-reload@a5f3062) Restructure test harness to actually evaluate script.
- [`5bab3c2`](ember-cli/ember-cli-inject-live-reload@5bab3c2) fix: add empty string in `dynamicScript`
- [`7f5ffad`](ember-cli/ember-cli-inject-live-reload@7f5ffad) fix: syntax error in `dynamicScript`
- [`21a7005`](ember-cli/ember-cli-inject-live-reload@21a7005) 2.0.0
- [`e754721`](ember-cli/ember-cli-inject-live-reload@e754721) Add v2.0.0 to CHANGELOG.md.
- Additional commits viewable in [compare view](rwjblue/ember-cli-inject-live-reload@v1.8.2...v2.0.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-cli-inject-live-reload&package-manager=npm_and_yarn&previous-version=1.8.2&new-version=2.0.1)](https://dependabot.com/compatibility-score.html?dependency-name=ember-cli-inject-live-reload&package-manager=npm_and_yarn&previous-version=1.8.2&new-version=2.0.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

Dependabot will **not** automatically merge this PR because it includes a major update to a development dependency.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blimmer @pangratz @dgeb @rwjblue @LevelbossMike @Turbo87