This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Utilize new destroy-app.js when present. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| description: 'Generates an acceptance test for a feature.', | ||
|
|
||
| locals: function() { | ||
| var destroyAppExists = existsSync(this.project.root + '/tests/helpers/destroy-app.js'); |
There was a problem hiding this comment.
Should probably use path.join here. Node might do the right thing on Windows, but I'm never certain...
There was a problem hiding this comment.
I always forget this. Fixed!
blimmer
force-pushed
the
utilize-destroy-app
branch
from
9912331 to
d07445b
Compare
1.13.9 of ember-cli will have a destroy-app.js similar to start-app.js. See [this PR](https://github.com/ember-cli/ember-cli/pull/4772/files). This patch uses that file if it's present.
blimmer
force-pushed
the
utilize-destroy-app
branch
from
d07445b to
6f89fa1
Compare
|
Rebased this - should be good to go to master. |
rwjblue
added a commit
that referenced
this pull request
Nov 9, 2015
Utilize new destroy-app.js when present.
|
thanks @blimmer! |
|
I updated @dgeb - Can you add me to |
|
@rwjblue sure thing - just added you |
|
Thank you, sir! Published as v0.9.5. |
|
Nice - glad not to be a blocker any more! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.13.9 of ember-cli will have a destroy-app.js similar to start-app.js. See this PR.
This patch uses that file if it's present.