This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Protect against NPE in linting config. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwjblue this was a blocker for us and necessitates 0.9.7 (IMO) |
|
Adding the guard is good, but can you also add this so that |
blimmer
force-pushed
the
bug/protect-linting-npe
branch
from
6c19883 to
13a8577
Compare
|
Added! |
| this._super.included(app); | ||
| included: function included(app, parentAddon) { | ||
| var target = (parentAddon || app); | ||
| this._super.included(target); |
There was a problem hiding this comment.
Sorry for the annoyance, can you tweak this to this._super.included.call(this, target)?
blimmer
force-pushed
the
bug/protect-linting-npe
branch
from
13a8577 to
e2c6f7c
Compare
rwjblue
added a commit
that referenced
this pull request
Nov 10, 2015
Protect against NPE in linting config.
|
Released as v0.9.7. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88.