Drop support for Node 16

ember-cli · Oct 3, 2023 · 36192d9 · 36192d9
1 parent a26fcb1
commit 36192d9
Show file tree

Hide file tree

Showing 44 changed files with 63 additions and 65 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,7 +29,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: 'yarn'
 
       - run: yarn install --frozen-lockfile --non-interactive
@@ -47,7 +47,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: 'yarn'
 
       - run: yarn install --frozen-lockfile --non-interactive
@@ -62,7 +62,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [16, 18, 20]
+        node-version: [18, 20]
         os: [ubuntu, windows]
 
     steps:
@@ -93,7 +93,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: 'yarn'
 
       - run: yarn install --frozen-lockfile --non-interactive

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -13,7 +13,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
 
       - run: yarn install --frozen-lockfile --non-interactive
 

diff --git a/blueprints/addon/files/.github/workflows/ci.yml b/blueprints/addon/files/.github/workflows/ci.yml
@@ -21,11 +21,11 @@ jobs:
       - uses: actions/checkout@v3<% if (pnpm) { %>
       - uses: wyvox/action-setup-pnpm@v2
         with:
-          node-version: 16<% } else { %>
+          node-version: 18<% } else { %>
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: <%= yarn ? 'yarn' : 'npm' %>
       - name: Install Dependencies
         run: <%= yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %><% } %>
@@ -43,11 +43,11 @@ jobs:
       - uses: actions/checkout@v3<% if (pnpm) { %>
       - uses: wyvox/action-setup-pnpm@v2
         with:
-          node-version: 16
+          node-version: 18
           no-lockfile: true<% } else { %>
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: <%= yarn ? 'yarn' : 'npm' %>
       - name: Install Dependencies
         run: <%= yarn ? 'yarn install --no-lockfile' : 'npm install --no-shrinkwrap' %><% } %>
@@ -76,11 +76,11 @@ jobs:
       - uses: actions/checkout@v3<% if (pnpm) { %>
       - uses: wyvox/action-setup-pnpm@v2
         with:
-          node-version: 16<% } else { %>
+          node-version: 18<% } else { %>
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: <%= yarn ? 'yarn' : 'npm' %>
       - name: Install Dependencies
         run: <%= yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %><% } %>

diff --git a/blueprints/addon/files/.travis.yml b/blueprints/addon/files/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "16"
+  - "18"
 
 dist: xenial
 

diff --git a/blueprints/addon/files/README.md b/blueprints/addon/files/README.md
@@ -7,7 +7,7 @@
 
 * Ember.js v4.8 or above
 * Ember CLI v4.8 or above
-* Node.js v16 or above
+* Node.js v18 or above
 
 
 ## Installation

diff --git a/blueprints/app/files/.github/workflows/ci.yml b/blueprints/app/files/.github/workflows/ci.yml
@@ -23,7 +23,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: <%= yarn ? 'yarn' : 'npm' %>
       - name: Install Dependencies
         run: <%= yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %><% } %>
@@ -41,7 +41,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: <%= yarn ? 'yarn' : 'npm' %>
       - name: Install Dependencies
         run: <%= yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %><% } %>

diff --git a/blueprints/app/files/.travis.yml b/blueprints/app/files/.travis.yml
@@ -1,7 +1,7 @@
 ---
 language: node_js
 node_js:
-  - "16"
+  - "18"
 
 dist: xenial
 

diff --git a/blueprints/app/files/package.json b/blueprints/app/files/package.json
@@ -110,7 +110,7 @@
     "webpack": "^5.88.2"
   },
   "engines": {
-    "node": "16.* || >= 18"
+    "node": ">= 18"
   },
   "ember": {
     "edition": "octane"

diff --git a/docs/node-support.md b/docs/node-support.md
@@ -17,7 +17,7 @@
 | 12.x             | 3.10.0 - 4.6.0               |
 | 13.x             | 3.15.0 - 3.20.0              |
 | 14.x             | 3.19.0 - 5.0.0               |
-| 16.x             | 3.28.0 - Current             |
+| 16.x             | 3.28.0 - 5.3.0             |
 | 18.x             | 4.6.0 - Current              |
 | 20.x             | 5.4.0 - Current              |
 
@@ -32,8 +32,6 @@ Node.js](https://github.com/nodejs/LTS#lts_schedule).
 
 ## Current support:
 
-* v16: Released as stable version then converted to LTS.
-  * Supported by ember-cli/ember-cli#master until: 2023-09-11.
 * v18: Released as stable version.
   * Supported by ember-cli/ember-cli#master until: 2025-04-30.
 * v20: Released as stable version.

diff --git a/package.json b/package.json
@@ -156,7 +156,7 @@
     "yuidocjs": "0.10.2"
   },
   "engines": {
-    "node": ">= 16"
+    "node": ">= 18"
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org"
@@ -172,7 +172,7 @@
     }
   },
   "volta": {
-    "node": "16.19.1",
+    "node": "18.12.0",
     "yarn": "1.22.19"
   }
 }
diff --git a/tests/fixtures/addon/defaults-travis/.travis.yml b/tests/fixtures/addon/defaults-travis/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "16"
+  - "18"
 
 dist: xenial
 

diff --git a/tests/fixtures/addon/defaults-travis/README.md b/tests/fixtures/addon/defaults-travis/README.md
@@ -9,7 +9,7 @@ Compatibility
 
 * Ember.js v4.8 or above
 * Ember CLI v4.8 or above
-* Node.js v16 or above
+* Node.js v18 or above
 
 
 Installation

diff --git a/tests/fixtures/addon/defaults-travis/package.json b/tests/fixtures/addon/defaults-travis/package.json
@@ -72,7 +72,7 @@
     "stylelint-prettier": "^2.0.0"
   },
   "engines": {
-    "node": "16.* || >= 18"
+    "node": ">= 18"
   },
   "ember": {
     "edition": "octane"

diff --git a/tests/fixtures/addon/defaults/.github/workflows/ci.yml b/tests/fixtures/addon/defaults/.github/workflows/ci.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
       - name: Install Dependencies
         run: npm ci
@@ -40,7 +40,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
       - name: Install Dependencies
         run: npm install --no-shrinkwrap
@@ -70,7 +70,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
       - name: Install Dependencies
         run: npm ci

diff --git a/tests/fixtures/addon/defaults/README.md b/tests/fixtures/addon/defaults/README.md
@@ -7,7 +7,7 @@
 
 * Ember.js v4.8 or above
 * Ember CLI v4.8 or above
-* Node.js v16 or above
+* Node.js v18 or above
 
 
 ## Installation

diff --git a/tests/fixtures/addon/defaults/package.json b/tests/fixtures/addon/defaults/package.json
@@ -76,7 +76,7 @@
     "ember-source": ">= 4.0.0"
   },
   "engines": {
-    "node": "16.* || >= 18"
+    "node": ">= 18"
   },
   "ember": {
     "edition": "octane"

diff --git a/tests/fixtures/addon/pnpm/.github/workflows/ci.yml b/tests/fixtures/addon/pnpm/.github/workflows/ci.yml
@@ -21,7 +21,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: wyvox/action-setup-pnpm@v2
         with:
-          node-version: 16
+          node-version: 18
       - name: Lint
         run: pnpm lint
       - name: Run Tests
@@ -36,7 +36,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: wyvox/action-setup-pnpm@v2
         with:
-          node-version: 16
+          node-version: 18
           no-lockfile: true
       - name: Run Tests
         run: pnpm test:ember
@@ -63,6 +63,6 @@ jobs:
       - uses: actions/checkout@v3
       - uses: wyvox/action-setup-pnpm@v2
         with:
-          node-version: 16
+          node-version: 18
       - name: Run Tests
         run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
diff --git a/tests/fixtures/addon/pnpm/README.md b/tests/fixtures/addon/pnpm/README.md
@@ -7,7 +7,7 @@
 
 * Ember.js v4.8 or above
 * Ember CLI v4.8 or above
-* Node.js v16 or above
+* Node.js v18 or above
 
 
 ## Installation

diff --git a/tests/fixtures/addon/pnpm/package.json b/tests/fixtures/addon/pnpm/package.json
@@ -77,7 +77,7 @@
     "ember-source": ">= 4.0.0"
   },
   "engines": {
-    "node": "16.* || >= 18"
+    "node": ">= 18"
   },
   "ember": {
     "edition": "octane"

diff --git a/tests/fixtures/addon/typescript/package.json b/tests/fixtures/addon/typescript/package.json
@@ -122,7 +122,7 @@
     "ember-source": ">= 4.0.0"
   },
   "engines": {
-    "node": "16.* || >= 18"
+    "node": ">= 18"
   },
   "ember": {
     "edition": "octane"

diff --git a/tests/fixtures/addon/yarn/.github/workflows/ci.yml b/tests/fixtures/addon/yarn/.github/workflows/ci.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: yarn
       - name: Install Dependencies
         run: yarn install --frozen-lockfile
@@ -40,7 +40,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: yarn
       - name: Install Dependencies
         run: yarn install --no-lockfile
@@ -70,7 +70,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: yarn
       - name: Install Dependencies
         run: yarn install --frozen-lockfile

diff --git a/tests/fixtures/addon/yarn/.travis.yml b/tests/fixtures/addon/yarn/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "16"
+  - "18"
 
 dist: xenial
 

diff --git a/tests/fixtures/addon/yarn/README.md b/tests/fixtures/addon/yarn/README.md
@@ -7,7 +7,7 @@
 
 * Ember.js v4.8 or above
 * Ember CLI v4.8 or above
-* Node.js v16 or above
+* Node.js v18 or above
 
 
 ## Installation

diff --git a/tests/fixtures/addon/yarn/package.json b/tests/fixtures/addon/yarn/package.json
@@ -77,7 +77,7 @@
     "ember-source": ">= 4.0.0"
   },
   "engines": {
-    "node": "16.* || >= 18"
+    "node": ">= 18"
   },
   "ember": {
     "edition": "octane"

diff --git a/tests/fixtures/app/defaults/.github/workflows/ci.yml b/tests/fixtures/app/defaults/.github/workflows/ci.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
       - name: Install Dependencies
         run: npm ci
@@ -39,7 +39,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
       - name: Install Dependencies
         run: npm ci

diff --git a/tests/fixtures/app/defaults/package.json b/tests/fixtures/app/defaults/package.json
@@ -72,7 +72,7 @@
     "webpack": "^5.88.2"
   },
   "engines": {
-    "node": "16.* || >= 18"
+    "node": ">= 18"
   },
   "ember": {
     "edition": "octane"

diff --git a/tests/fixtures/app/embroider-no-welcome/package.json b/tests/fixtures/app/embroider-no-welcome/package.json
@@ -72,7 +72,7 @@
     "webpack": "^5.88.2"
   },
   "engines": {
-    "node": "16.* || >= 18"
+    "node": ">= 18"
   },
   "ember": {
     "edition": "octane"