Update to use node version >= 8 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 This'll need to be a major as it's a breaking change, I believe. |
Yes |
choheekim
force-pushed
the
node-version-bump
branch
3 times, most recently
from
ca79ae8 to
db49a7d
Compare
…e-snippet. We are using ember-cli-addon-docs has dependency of ember-code-snippet@^2.4.0 in ember-exam and they released new version (2.4.1) with the changes that make the engine incompatible with node version 6.
choheekim
force-pushed
the
node-version-bump
branch
2 times, most recently
from
700a90a to
eaf25fe
Compare
|
A pr in |
choheekim
force-pushed
the
node-version-bump
branch
from
d545172 to
eaf25fe
Compare
scalvert
reviewed
Jul 15, 2019
choheekim
force-pushed
the
node-version-bump
branch
from
8e57820 to
d2abe64
Compare
|
Just want to verify, we went from |
|
|
(assuming we do a major version bump due to node engine change)
|
@step2yeung we used ^8.10.0 |
|
Merged! Next will release a major version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-exam CI has been failing due to dependency issue with
ember-code-snippet. We are using ember-cli-addon-docs has dependency of ember-code-snippet@^2.4.0 in ember-exam and they released new version (2.4.1) with the changes that make the engine incompatible with node version 6.