Embroider support when staticAddonTestSupportTrees enabled
#599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoov
changed the title
This was referenced Sep 29, 2020
thoov
force-pushed
the
embroider-macros
branch
from
76707da to
d8f07ea
Compare
|
@thoov looks like you took out the WIP tag, so this PR is good for review? |
thoov
force-pushed
the
embroider-macros
branch
from
cd9fd18 to
1115053
Compare
|
@step2yeung, yes this is ready for review. But it needs #600 first. |
thoov
force-pushed
the
embroider-macros
branch
from
f685c18 to
54643a1
Compare
|
@step2yeung / @rwjblue / @ef4 This is ready for review |
rwjblue
changed the title
staticAddonTestSupportTrees enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
@embroider/macrosto restructure test loader logic to work when staticAddonTestSupportTrees is enabled.This PR is dependent on #600 as this has been based off of that (the change set here contains most of that work but can be rebased once that lands).
Fixes: #490