Ember exam failing when browser ID not found, return 0 #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has sporadic reports of ember-exam failing for "Browser ID not found" in v4.0.9, even though all the tests from execution has completed. So failing the test execution when all tests pass because of test infrastructure is a bad experience for users.
Context:
getBrowserIdis used for the debug logs & execution file to map the test modules to a browser Id. The logs from the failure has always been from writing to the debug logs. My hunch is the launcher settings is cleared (a race condition) before it's used to for the debug log.This change will
console.warnrather than throw new Error when there are problems with getting thebrowserIdfromlauncher.settings.test_page. This way, the execution should finish successfully even if it wasn't able to get the browserId.