Update ember-cli to 1.13.8, use simplified initializer pattern #16
Conversation
mike-north
force-pushed
the
ember-cli-1.13.8
branch
from
6397ac3
to
f273c6e
Compare
| @@ -1,7 +1,8 @@ | |||
| import Ember from 'ember'; | |||
| import config from '../config/environment'; | |||
|
|
|||
| export function initialize(container, application) { | |||
| export function initialize() { | |||
| var application = arguments[1] || arguments[0]; | |||
There was a problem hiding this comment.
@rwjblue @stefanpenner if this is an acceptable fix, I'm happy to apply this pattern to ember's internal initializers. Canary is currently throwing warnings, so I assume they'll need to be handled before cutting the next beta
There was a problem hiding this comment.
@mike-north - Are you saying that the initializers that are internal to Ember itself are triggering this deprecation? Can you open an issue for that (the fix in Ember itself isn't quite like this though)?
There was a problem hiding this comment.
Are you saying that the initializers that are internal to Ember itself are triggering this deprecation?
Yes
Can you open an issue for that
I'll open a PR. The particulars of the fix are likely to be simple enough that I don't mind having to re-do them after feedback
There was a problem hiding this comment.
Sounds good. The solution in Ember is to import isEnabled and use different signatures based on the flag being enabled. Also, I'm concerned that our tests did not show this (we throw errors if we hit a deprecation).
|
Just ran into this bug when working on running the LiquidFire test server (as I'm starting on some docs changes here: emberjs/guides#448 (comment)), which also works against |
Update ember-cli to 1.13.8, use simplified initializer pattern
|
Released as 1.0.4. |
|
👍 |
In canary, the initializer was was throwing a deprecation warning due to: emberjs/ember.js#11440