Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use remote-git-tags instead of GitHub API #12

Merged
merged 2 commits into from
Nov 6, 2017

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 6, 2017

@Turbo87 Turbo87 requested a review from rwjblue November 6, 2017 11:07
@rwjblue
Copy link
Member

rwjblue commented Nov 6, 2017

Two concerns:

  1. From the README I’d remote-git-tags:

I'm using this successfully against GitHub repos, but the underlaying modules are not that actively maintained, so I wouldn't recommend using this for production critical code.

  1. Doesn’t github also rate limit access to the git:// remotes by IP?

@Turbo87
Copy link
Member Author

Turbo87 commented Nov 6, 2017

Doesn’t github also rate limit access to the git:// remotes by IP?

not that I'm aware of, haven't found any information on that. and if it did then services like TravisCI wouldn't work well since they need to clone thousands of projects every minute/second/whatever.

I'm using this successfully against GitHub repos, but the underlaying modules are not that actively maintained, so I wouldn't recommend using this for production critical code.

yeah, I read that too, but if something breaks we can probably just fork and provide a fixed version. in any case this solution seems easier and less brittle than what we currently have and doesn't require an extra deploy step for Ember.js.

@rwjblue
Copy link
Member

rwjblue commented Nov 6, 2017

Seems good to me. Thanks for putting this together!

@rwjblue
Copy link
Member

rwjblue commented Nov 6, 2017

@kategengler - Any objections?

@kategengler
Copy link
Member

Nope, looks good to me though I'd still like to explore a npm info solution.

@kategengler kategengler merged commit 564ab7d into ember-cli:master Nov 6, 2017
@Turbo87 Turbo87 deleted the remote-git-tags branch November 6, 2017 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants