Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does ember-try-config need to be a dev dependency? #77

Closed
nbrookie opened this issue Jun 22, 2016 · 3 comments
Closed

Does ember-try-config need to be a dev dependency? #77

nbrookie opened this issue Jun 22, 2016 · 3 comments

Comments

@nbrookie
Copy link

Hey ember-try devs,

I ran into an issue when trying to install a package that relied on ember-try (see below).
Does the ember-try-config package need to be a dependency for ember-try?

The following is taken from this issue: sir-dunxalot/ember-google-charts#22

$ ember install ember-google-charts                          
Cannot find module 'ember-try-config'
Error: Cannot find module 'ember-try-config'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/Users/me/dev/frontend/node_modules/ember-cli/node_modules/ember-try/lib/utils/config.js:7:34)
    at Module._compile (module.js:397:26)
    at Object.Module._extensions..js (module.js:404:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)

I was able to install ember-google-charts by doing the following:

$ npm install ember-try-config
(...snip...)
$ ember install ember-google-charts

My current setup is:

  • ember-cli 2.6.1
  • npm 5.4.1
@rwjblue
Copy link
Member

rwjblue commented Jun 23, 2016

Does the ember-try-config package need to be a dependency for ember-try?

Yep, that is why it is listed here: https://github.com/ember-cli/ember-try/blob/master/package.json#L63

@nbrookie
Copy link
Author

Ah, got it. Thx @rwjblue. Maybe this is an issue with ember-google-charts specifying an old version of ember-try in their package.json? They are currently specifying 0.0.6.

@kategengler
Copy link
Member

Anybody seen this lately?

luxzeitlos pushed a commit to luxzeitlos/ember-try that referenced this issue Sep 27, 2017
Support explicitly configuring header and footer modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants