Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chained commands and setting env vars in commands #107

Merged
merged 4 commits into from
Oct 31, 2016

Conversation

kategengler
Copy link
Member

  • Add note to readme about needing to npm link ember-try

Allows:

ember try:one <scenario> --- FOO=5 ember test
ember try:one <scenario> --- 'ember test && echo 2' (note quotes)

The same goes for the command in the config file.

Fixes #94 and #87

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, do we run appveyor (to confirm windows changes work)?

@kategengler
Copy link
Member Author

@rwjblue See #97 re: appveyor. Plan to at least manually check windows for now.

@rwjblue
Copy link
Member

rwjblue commented Oct 27, 2016

Sounds good.

@kategengler
Copy link
Member Author

Manually checked on windows: All the previous types of commands seem to work, but chained commands do not.

@kategengler kategengler changed the title Allow chained commands and setting env vars in commands WIP Allow chained commands and setting env vars in commands Oct 27, 2016
@kategengler
Copy link
Member Author

kategengler commented Oct 27, 2016

On linux, npm link; npm link ember-try doesn't seem to be enough to get the ember try commands run to use the checked out version and not the version included by ember-cli.

@kellyselden
Copy link
Member

FOO=5 ember test is invalid syntax on Windows. I've always used cross-env for setting env vars multi-platform. (here for example)

@kategengler
Copy link
Member Author

@kellyselden cross-env probably works already, since it's a command. Part of this work was to allow setting environment variables in the command passed to ember-try. The later part, which should be possible, isn't working on windows (chained commands with && or ||), though it might be the same issue as what I'm seeing on linux: When all-commands.sh is run, the commands use the ember-try included with ember-cli, rather than the working copy.

@kategengler kategengler changed the title WIP Allow chained commands and setting env vars in commands Allow chained commands and setting env vars in commands Oct 31, 2016
@kategengler kategengler merged commit 30477e1 into master Oct 31, 2016
@kategengler kategengler deleted the kg-allow-compound-commands branch October 31, 2016 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants