Skip to content

Commit

Permalink
Merge pull request #1385 from ember-learn/use-data-diffs
Browse files Browse the repository at this point in the history
refactor: use data diff in md
  • Loading branch information
mansona authored Jul 23, 2024
2 parents ecdb88f + 29e798f commit 602983a
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,12 @@ displayId: ember-cli.blacklist-whitelist-build-options
Using the `blacklist` and `whitelist` build options has been deprecated. Please
use `exclude` and `include` respectively instead.

```diff
// ember-cli-build.js

```js {data-filename="ember-cli-build.js" data-diff="-4,+5"}
module.exports = function (defaults) {
const app = new EmberApp(defaults, {
addons: {
- blacklist: ['addon-name'],
+ exclude: ['addon-name'],
blacklist: ['addon-name'],
exclude: ['addon-name'],
},
};
};
Expand Down
18 changes: 9 additions & 9 deletions content/ember-cli/v5/ember-cli-output-paths-build-option.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,21 @@ Using the `outputPaths` build option is deprecated, as output paths will no long

To resolve the deprecation, please remove the `outputPaths` build option from your `ember-cli-build.js` file:

```diff
```js {data-diff="-3,-4,-5,-6,-7"}
module.exports = function (defaults) {
const app = new EmberApp(defaults, {
- outputPaths: {
- app: {
- js: `/assets/foo.js`,
- },
- },
outputPaths: {
app: {
js: `/assets/foo.js`,
},
},
};
};
```
And update your `app/index.html` file accordingly:
```diff
```html {data-diff="-20,+21"}
<!DOCTYPE html>
<html>
<head>
Expand All @@ -44,8 +44,8 @@ And update your `app/index.html` file accordingly:
{{content-for "body"}}

<script src="{{rootURL}}assets/vendor.js"></script>
- <script src="{{rootURL}}assets/foo.js"></script>
+ <script src="{{rootURL}}assets/my-app-name.js"></script>
<script src="{{rootURL}}assets/foo.js"></script>
<script src="{{rootURL}}assets/my-app-name.js"></script>

{{content-for "body-footer"}}
</body>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Deprecates `schema.attributesDefinitionFor(type)` and `schema.relationshipsDefin

To resolve change:

```diff
- store.getSchemaDefinitionService().attributesDefinitionFor('user')
+ store.getSchemaDefinitionService().attributesDefinitionFor({ type: 'user' })
```js {data-diff="-1,+2"}
store.getSchemaDefinitionService().attributesDefinitionFor('user')
store.getSchemaDefinitionService().attributesDefinitionFor({ type: 'user' })
```

0 comments on commit 602983a

Please sign in to comment.