Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 404 page as in the API docs #1391

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Implement 404 page as in the API docs #1391

merged 2 commits into from
Jul 24, 2024

Conversation

MinThaMie
Copy link
Contributor

fixes #70
Screenshot 2024-07-23 at 14 27 01

@MinThaMie MinThaMie requested review from mansona and jenweber July 23, 2024 12:27
@MinThaMie MinThaMie self-assigned this Jul 23, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 23, 2024 •
edited
Loading

✅ Deploy Preview for ember-deprecations ready!

Name Link
🔨 Latest commit 9363553
🔍 Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/66a0c09d405d2e0008268c59
😎 Deploy Preview https://deploy-preview-1391--ember-deprecations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MinThaMie MinThaMie added the enhancement New feature or request label Jul 23, 2024
@MinThaMie
Copy link
Contributor Author

@mansona I need help on how to make sure netlify is not hyjacking this :)

@MinThaMie MinThaMie force-pushed the 404-page branch 2 times, most recently from b18de19 to 85ca320 Compare July 24, 2024 07:41
mansona
mansona approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mansona
Copy link
Member

mansona commented Jul 24, 2024

I just rebased this because of the strange git history shenanigans 🤔 there should be no changes in the code 👍

@mansona mansona merged commit 70ea0df into main Jul 24, 2024
4 checks passed
@mansona mansona deleted the 404-page branch July 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

@jenweber jenweber Awaiting requested review from jenweber

Assignees

@MinThaMie MinThaMie

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement 404 page
2 participants
@MinThaMie @mansona