Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API docs styling tweaks #881

Merged
merged 9 commits into from
Sep 7, 2023
Merged

Conversation

lukasnys
Copy link

@lukasnys lukasnys commented Sep 2, 2023

Fixes #879 as well as some other styling tweaks:

Let me know if one of the additional styling tweaks (font-size changes, header width changes, sidebar width changes) are undesired as I didn't talk this through with anyone.

Screenshots before and after
x Before After
Desktop localhost_4200_ember_release (2) localhost_4200_ember_release (1)
Mobile localhost_4200_ember_release_modules_@ember%2Farray (2) localhost_4200_ember_release_modules_@ember%2Farray (3)
Mobile sidebar localhost_4200_ember_release_modules_@ember%2Farray (4) localhost_4200_ember_release_modules_@ember%2Farray (5)

@lukasnys lukasnys changed the base branch from master to website-redesign September 2, 2023 12:00
@lukasnys lukasnys force-pushed the wide-mode branch 2 times, most recently from ec3d802 to 885c694 Compare September 2, 2023 12:21
@lukasnys
Copy link
Author

lukasnys commented Sep 2, 2023

One thing I'm concerned with in this PR is the --sidebar-width: min-content. I added it to stop sidebar items from overflowing their parent, however if the sidebar items ever become smaller in size, it might cause the layout to "break"

@lukasnys lukasnys marked this pull request as ready for review September 2, 2023 12:45
@MinThaMie MinThaMie self-requested a review September 7, 2023 15:09
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct when I understand that you made it min-content because the sidebar-items were not wrapping? Because I think we would love it if the sidebar-width is consistent between all the "apps"/websites and using min-content does not guarantee that. So if that's what you are aiming for, I suggest using word-wrap.

@mansona mansona temporarily deployed to ember-api-do-wide-mode-fwwuluy September 7, 2023 15:16 Inactive
@MinThaMie MinThaMie merged commit ef4d2e1 into ember-learn:website-redesign Sep 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Start using "wide mode" in the redesign branch
3 participants