Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog(octanespecial): how to migrate to octane #480

Merged
merged 3 commits into from
Jan 10, 2020
Merged

blog(octanespecial): how to migrate to octane #480

merged 3 commits into from
Jan 10, 2020

Conversation

chrisrng
Copy link
Member

@chrisrng chrisrng commented Jan 9, 2020

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Jan 9, 2020
jayjayjpg
jayjayjpg approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! I left two more small suggestions, but otherwise this seems good to go! Thank you for this great ✨ writeup for the Octane special this week

source/2020-01-10-the-ember-times-issue-130.md Outdated Show resolved Hide resolved
source/2020-01-10-the-ember-times-issue-130.md Show resolved Hide resolved
chrisrng and others added 2 commits January 9, 2020 18:14
@chrisrng @jayjayjpg
Update source/2020-01-10-the-ember-times-issue-130.md
3e44160 
Co-Authored-By: Jessica Jordan <jessica.jordan.fe.dev@gmail.com>
@chrisrng @jayjayjpg
Update source/2020-01-10-the-ember-times-issue-130.md
2d076f4 
Co-Authored-By: Jessica Jordan <jessica.jordan.fe.dev@gmail.com>
@chrisrng chrisrng merged commit 133e011 into blog/embertimes-octane-special Jan 10, 2020
@chrisrng chrisrng deleted the chrisrng-patch-1 branch January 10, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisrng @jayjayjpg