Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Covered v1 release of QUnit DOM #519

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Covered v1 release of QUnit DOM #519

merged 1 commit into from
Feb 5, 2020

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Feb 5, 2020

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Feb 5, 2020
MinThaMie
MinThaMie approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a link to some more new features next to the chaining. Then you could add that still ;)

@ijlee2
Copy link
Member Author

ijlee2 commented Feb 5, 2020

Is there a link to some more new features next to the chaining. Then you could add that still ;)

Thanks for a quick review!

I'd like to mention more things about the new release, but the project has been too stable that the other additions hasProperty and doesNotHaveStyle didn't feel as groundbreaking as chaining. (Not to diminish those who worked on these two.)

I think hasProperty may be something that we can mention, but at the moment, I'm not sure how it's different from hasAttribute. Let me merge this PR now, while I wait for Tobias for clarification with hasProperty. If I can come up with an example for hasProperty, I'll make a new PR to include that.

@ijlee2 ijlee2 merged commit c771988 into ember-learn:blog/embertimes-134 Feb 5, 2020
@ijlee2 ijlee2 deleted the blog/embertimes-134 branch February 5, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinThaMie MinThaMie MinThaMie approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijlee2 @MinThaMie