Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provided more information for QUnit DOM v1 release #521

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Provided more information for QUnit DOM v1 release #521

merged 1 commit into from
Feb 7, 2020

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Feb 6, 2020

I asked Tobias for clarification about hasProperty and learned that there are some differences between it and hasAttribute. I included examples to help readers understand the differences.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Feb 6, 2020
amyrlam
amyrlam approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks for your attention to detail, as always!

@amyrlam amyrlam merged commit f57ba3d into ember-learn:blog/embertimes-134 Feb 7, 2020
@ijlee2 ijlee2 deleted the blog/embertimes-134 branch February 7, 2020 04:59
jayjayjpg pushed a commit to jayjayjpg/ember-blog that referenced this pull request Feb 7, 2020
@amyrlam @jayjayjpg
Merge pull request ember-learn#521 from ijlee2/blog/embertimes-134
c81ff36 
Provided more information for QUnit DOM v1 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyrlam amyrlam amyrlam approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijlee2 @amyrlam