Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a section on Community case highlight (issue 93) #62

Merged
merged 7 commits into from
Apr 11, 2019
Merged

Added a section on Community case highlight (issue 93) #62

merged 7 commits into from
Apr 11, 2019

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Apr 11, 2019

What it does

I added a section highlighting the benefits of Ember community. I also added my name to the list of authors.

Related Issue(s)

The added section goes with issue 93 (#60).

Copy link
Member

@chrisrng chrisrng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great write up! Can we also add a short blurb at the top around L13

- [Documentations](https://guides.emberjs.com/release/) (71%)
- [Ember.js blog](https://blog.emberjs.com/) (54%)
- [RFCs](https://github.com/emberjs/rfcs) (52%)
- Code samples (51%)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on linking to twiddle?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with both including the link and leaving as is.

I didn't include a link because code samples, to me, may be a part of a blog post or documentation. I wasn't sure what link would make a good representative, and hadn't thought about Ember Twiddle.

source/2019-04-05-the-ember-times-issue-93.md Outdated Show resolved Hide resolved
source/2019-04-05-the-ember-times-issue-93.md Outdated Show resolved Hide resolved
@ijlee2
Copy link
Member Author

ijlee2 commented Apr 11, 2019

Great write up! Can we also add a short blurb at the top around L13

Thanks!

I left the blurb empty in case @MinThaMie will give a summary in her introduction. What do you think, @MinThaMie and @chrisrng ?

Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac - awesome writeup, I'm impressed ✨

Thanks again for coming to the meeting yesterday and brainstorming with us, was super helpful!

source/2019-04-05-the-ember-times-issue-93.md Outdated Show resolved Hide resolved
chrisrng and others added 4 commits April 11, 2019 14:38
Co-Authored-By: ijlee2 <16869656+ijlee2@users.noreply.github.com>
Co-Authored-By: ijlee2 <16869656+ijlee2@users.noreply.github.com>
Co-Authored-By: ijlee2 <16869656+ijlee2@users.noreply.github.com>
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great ✨ Thank you for this amazing writeup for our first special edition 💯

@jayjayjpg jayjayjpg merged commit 7f6b0fa into ember-learn:blog/embertimes-93 Apr 11, 2019
@ijlee2 ijlee2 deleted the blog/embertimes-93 branch September 10, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants