support angle brackets with docs-demo component #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following snippet wasn't getting picked up by the original regex: ```hbs <DocsDemo as |demo|> <demo.example @name='button-example.hbs'> <MyButton> Click Me </MyButton> </demo.example> <demo.snippet @name='button-example.hbs'/> </DocsDemo> ``` This shouldn't break existing classic component invocation of `docs-demo`.
dfreeman
reviewed
Apr 4, 2019
| begin: /{{#(?:docs-snippet|demo.example)\sname=(?:"|')(\S+)(?:"|')/, | ||
| end: /{{\/(?:docs-snippet|demo.example)}}/, | ||
| begin: /(?:{{#|<)(?:docs-snippet|demo.example)\s@?name=(?:"|')(\S+)(?:"|')/, | ||
| end: /(?:{{|<)\/(?:docs-snippet|demo.example)(?:}}|>)/, |
There was a problem hiding this comment.
For this to work for standalone snippets, we'd need to accept DocsSnippet here as well, wouldn't we?
There was a problem hiding this comment.
Ah, yeah that’s right. Good catch.
|
Nowhere! I’m not sure where to start with a test for this 😞 |
|
@noslouch I think what I'd do is add a route in the testing addon (under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following snippet wasn't getting picked up by the original regex:
This shouldn't break existing classic component invocation of
docs-demo.