Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Add config options to indicate the file extensions that ember-code-snippet needs to use #411

Conversation

dmuneras
Copy link
Contributor

Description

Since this PR: https://github.com/ef4/ember-code-snippet/pull/59/files it is possible to indicate the extensions to look for snippets. This PR just add the option to use the functionality.

I added a new section to the documentation to let people know that this new option exists.

Screenshot 2019-10-13 at 20 01 59

…ember-code-snippet needs to use

Since this PR: https://github.com/ef4/ember-code-snippet/pull/59/files it is possilbe to indicate the extensions to look for snippets, this PR just add the option to use the functionlity
@dmuneras
Copy link
Contributor Author

Hi @samselikoff,

I just want to check if this PR still valid or if it needs extra work to be able to make it into.

Best regards,
Daniel.

@samselikoff
Copy link
Contributor

Looks awesome – nice work! Thanks <3

@samselikoff samselikoff merged commit 7574272 into ember-learn:master Oct 28, 2019
@dmuneras dmuneras deleted the enhancement/allow_users_to_modify_code_snippet_extensions branch October 28, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants