Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs heading styles due to Tailwind's v1 preflight #443

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Fix docs heading styles due to Tailwind's v1 preflight #443

merged 1 commit into from
Jan 16, 2020

Conversation

josemarluedke
Copy link
Contributor

Before:

Screen Shot 2020-01-03 at 10 06 35 AM

After

Screen Shot 2020-01-03 at 10 06 50 AM

RobbieTheWagner
RobbieTheWagner requested changes Jan 3, 2020
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there was an extra space. If we remove that, should be good to go!

addon/styles/components/_docs-md.scss Outdated Show resolved Hide resolved
@josemarluedke josemarluedke force-pushed the fix/styles-due-to-preflight branch from 6242f01 to 8867316 Compare January 3, 2020 18:56
@RobbieTheWagner RobbieTheWagner merged commit b180220 into ember-learn:master Jan 16, 2020
jamescdavis added a commit to typed-ember/ember-cli-typescript that referenced this pull request Jan 18, 2020
@jamescdavis
chore(deps): upgrade dependency ember-cli-addon-docs to b180220
65164e6 
so we get ember-learn/ember-cli-addon-docs#443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josemarluedke @RobbieTheWagner