Fix doc typo #456
Merged
Fix doc typo #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`docs/template.hbs` is the incorrect file name, the file it asks you to create should match the title of the `docs-snippet`
|
Yes, but pods are not the community-supported pattern. The official documentation should reflect the way that the community writes code according to the official Ember guides (classic and/or Octane) |
|
Also, it's internally inconsistent, as you can see the snippet tells you a different filepath altogether. |
RobbieTheWagner
approved these changes
Feb 28, 2020
|
@elwayman02 mind rebasing with master please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/template.hbsis the incorrect file name, the file it asks you to create should match the title of thedocs-snippet