Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node: current to targets for dummy app #390

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Conversation

mansona
Copy link
Member

@mansona mansona commented Apr 16, 2021

This should address the issue with #386

I also needed to bump the ember-source version because there was a patch version of 3.25 that fixed an underlying issue of the ember-source code not transpiling correctly for fastboot emberjs/ember.js#19397

I have verified that this fix does solve the issue locally 👍

Closes #386
Closes #387

@mansona mansona requested a review from a team April 16, 2021 12:18
@jenweber
Copy link
Contributor

Chris’s and I chatted about this! Seems good to me!

@mansona mansona merged commit d554483 into master Apr 16, 2021
@mansona mansona deleted the add-correct-node-target branch April 16, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Node engine version
2 participants