Update docs to use prefixed this. in templates
#349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
approved these changes
Jan 7, 2019
|
@mansona thank you so much! |
|
@chadhietala no, thank you! 😂 every line that I changed in the current version of the guides I was double and triple checking against your work so it was a major help 🎉 |
rwjblue
added a commit
to rwjblue/ember-cli
that referenced
this pull request
Jan 8, 2019
As part of [emberjs/rfcs#308](https://emberjs.github.io/rfcs/0308-deprecate-property-lookup-fallback.html#transition-path)'s phase 2. The main guides/docs have been updated (will be deployed with 3.7 docs) in ember-learn/guides-source#349.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149
This is essentially continuing the work that @chadhietala did in #149 but updated to the latest version folder.
This is a manual PR that used the previous PR as a visual input and a tool to extract handlebars code samples from the markdown files. I'm happy to share that script if anyone is interested in it but I just don't know where it should go 😂