Skip to content

Commit

Permalink
[DEPRECATION] RFC-522 implementation to add deprecations (#6390)
Browse files Browse the repository at this point in the history
* [DEPRECATION] RFC-522 implementation to add deprecations for default serializers and adapters

* improve deprecation

* Fixing some deprecations, adding deprecatedTest

* Updating deprecations to include url

* Updating deprecations to include url

* Reverting a test change and matching deprecation id to link

* Updating deprecation descriptions

* Fixing test description

* Fixing eslint issues

* Update packages/-ember-data/tests/integration/store/serializer-for-test.js

Co-Authored-By: Chris Thoburn <runspired@users.noreply.github.com>

* Update packages/store/addon/-private/system/core-store.ts

Co-Authored-By: Chris Thoburn <runspired@users.noreply.github.com>

* Update packages/store/addon/-private/system/core-store.ts

Co-Authored-By: Chris Thoburn <runspired@users.noreply.github.com>

* Update packages/store/addon/-private/system/core-store.ts

Co-Authored-By: Chris Thoburn <runspired@users.noreply.github.com>

* Update packages/store/addon/-private/system/model/model.js

Co-Authored-By: Chris Thoburn <runspired@users.noreply.github.com>

* Update packages/store/addon/-private/system/core-store.ts

Co-Authored-By: Chris Thoburn <runspired@users.noreply.github.com>

* Reverting removing a test

* Formatting issue

* More formatting issues for deprecation messages

* Fixing missing testInDebug import

* Update packages/store/addon/-private/system/core-store.ts

Co-Authored-By: Chris Thoburn <runspired@users.noreply.github.com>

* Update packages/store/addon/-private/system/core-store.ts

Co-Authored-By: Chris Thoburn <runspired@users.noreply.github.com>

* Update packages/store/addon/-private/system/core-store.ts

Co-Authored-By: Chris Thoburn <runspired@users.noreply.github.com>

* Update packages/store/addon/-private/system/model/model.js

Co-Authored-By: Chris Thoburn <runspired@users.noreply.github.com>
  • Loading branch information
pete-the-pete and runspired committed Sep 18, 2019
1 parent b3d5da4 commit 4551d05
Show file tree
Hide file tree
Showing 10 changed files with 290 additions and 226 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import Store, {
setIdentifierResetMethod,
setIdentifierForgetMethod,
} from '@ember-data/store';
import JSONAPIAdapter from '@ember-data/adapter/json-api';
import JSONAPISerializer from '@ember-data/serializer/json-api';
import Model, { attr, belongsTo } from '@ember-data/model';
import Adapter from '@ember-data/adapter';
import Serializer from '@ember-data/serializer';
Expand All @@ -27,6 +29,9 @@ if (IDENTIFIERS) {
hooks.beforeEach(function() {
const { owner } = this;

owner.register('adapter:application', JSONAPIAdapter.extend());
owner.register('serializer:application', JSONAPISerializer.extend());

class User extends Model {
@attr() firstName: string;
@attr() username: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import { get } from '@ember/object';
import { setupTest } from 'ember-qunit';
import Model from 'ember-data/model';
import Store from 'ember-data/store';
import JSONAPIAdapter from '@ember-data/adapter/json-api';
import JSONAPISerializer from '@ember-data/serializer/json-api';
import { module, test } from 'qunit';
import { settled } from '@ember/test-helpers';
import EmberObject from '@ember/object';
Expand Down Expand Up @@ -136,6 +138,8 @@ module('integration/record-data - Custom RecordData Implementations', function(h
owner.register('model:person', Person);
owner.register('model:house', House);
owner.register('service:store', CustomStore);
owner.register('adapter:application', JSONAPIAdapter.extend());
owner.register('serializer:application', JSONAPISerializer.extend());
});

test('A RecordData implementation that has the required spec methods should not error out', async function(assert) {
Expand Down
Loading

0 comments on commit 4551d05

Please sign in to comment.