many-array, flushCanonical bug when saving newly created elements

[olivierchatry]

So here is my problem :

• I have a project that can contains subProject
• I'm using firebase
• I create a new subProject, then save it, then save the project, so that all data and relations are saved.
• Id I do the opposite ( save project, then save subProject ), then the sub-project new sub project get added twice, until I reload

Looking at the code of many-array, I can see why it is doing that :

    flushCanonical: function flushCanonical() {
      //TODO make this smarter, currently its plenty stupid
      var toSet = this.canonicalState.filter(function (internalModel) {
        return !internalModel.isDeleted();
      });

      //a hack for not removing new records
      //TODO remove once we have proper diffing
      var newRecords = this.currentState.filter(function (internalModel) {
        return internalModel.isNew();
      });
      toSet = toSet.concat(newRecords);
      var oldLength = this.length;
      this.arrayContentWillChange(0, this.length, toSet.length);
      this.set('length', toSet.length);
      this.currentState = toSet;
      this.arrayContentDidChange(0, oldLength, this.length);
      //TODO Figure out to notify only on additions and maybe only if unloaded
      this.relationship.notifyHasManyChanged();
      this.record.updateRecordArrays();
    },

The problems occurs with

      var newRecords = this.currentState.filter(function (internalModel) {
        return internalModel.isNew();
      });

The record is already in the relation, and get added again because it was not saved. Canonical state is fine, but the currentState is not.

I think I can try to fix that, if it is OK ?