Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONAPISerializer should preserve lid in payloads #7956

Closed
runspired opened this issue Apr 16, 2022 · 2 comments · Fixed by #9246
Closed

JSONAPISerializer should preserve lid in payloads #7956

runspired opened this issue Apr 16, 2022 · 2 comments · Fixed by #9246
Labels
feature-suggestion good-first-issue

Comments

@runspired
Copy link
Contributor

While we don't care to maintain that serializer that much, we should make sure it takes advantage of the feature if someone is using it and configures their API :)
@sly7-7
Copy link
Contributor

sly7-7 commented Mar 5, 2024

🤦 I think this is the one I hit. So I'm making a PR.

@runspired
Copy link
Contributor Author

@sly7-7 thanks! meant to tell you that earlier, glad you realized 🤦‍♂️

sly7-7 added a commit to sly7-7/data that referenced this issue Mar 5, 2024
@sly7-7
normalization in json-api serializer preserves lid emberjs#7956
3455e85
@sly7-7 sly7-7 mentioned this issue Mar 5, 2024
Merged
sly7-7 added a commit to sly7-7/data that referenced this issue Mar 6, 2024
@sly7-7
normalization in json-api serializer preserves lid emberjs#7956
5a29464
runspired pushed a commit that referenced this issue Mar 8, 2024
@sly7-7
normalization in json-api serializer preserves lid #7956 (#9246)
f6f86e6
@runspired runspired mentioned this issue May 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-suggestion good-first-issue
Projects
EmberData
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

normalization in json-api serializer preserves lid #7956 sly7-7/data
2 participants
@runspired @sly7-7