[WIP] Fix for emmbeded records mixin to make it work with rails. #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New object creation duplicate fix:
Client id merged from https://github.com/tstirrat/ember-data/tree/embedded-client-id
- Add '_attributes'
- Support for ids deserialization (default in ActiveModel::Serializers)
- Support for deletion of objects by '_destroy'
Conflicts: lib/ember-addon/blueprints/ember-data/index.js
…ect creation duplicate fix: Client id merged from https://github.com/tstirrat/ember-data/tree/embedded-client-id - Add '_attributes' - Support for ids deserialization (default in ActiveModel::Serializers) - Support for deletion of objects by '_destroy'
simcha
changed the title
Conflicts: .gitignore packages/ember-data/tests/integration/serializers/embedded_records_mixin_test.js
Conflicts: packages/ember-data/lib/serializers/embedded_records_mixin.js packages/ember-data/tests/integration/serializers/embedded_records_mixin_test.js
…-master Conflicts: packages/ember-data/lib/serializers/embedded_records_mixin.js
|
Hi @simcha. Thanks for taking the time to work on this pr and sorry for not giving you any feedback until now. Unfortunately, I don't think we can introduce these changes into Ember Data's existing Instead, I think this would code make a great ember addon. If you have any trouble porting this to an addon please let me know and I would be happy to assist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I made some changes to EmbeddedRecordMixin to make it work with rails
It shall not brake non rails JSON and i have fixed the tests as well as added some new ones.
It is work in progress I do not like the client_id idea end especially the way it is stored in Ember. Same goes for the list of deleted records. But I think some subset of the solution or all of it after fixing could be useful for the others. I hope you can guide me in proper direction. Thanks in advance.