Handle null/empty type paths in build url mixin #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (type) { url.push(this.pathForType(type)); } | ||
| if (type && (path = this.pathForType(type))) { |
There was a problem hiding this comment.
Can you take the assignment out of the if statement? I don't think it's needed there.
|
Thanks for the PR! |
handle empty values returned by pathForType in buildURL method of the build url mixin. refs emberjs#2844
|
PR updated @igorT |
igorT
added a commit
that referenced
this pull request
Apr 1, 2015
Handle null/empty type paths in build url mixin
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle empty values returned by pathForType in buildURL method of
the build url mixin.
refs #2844