Fix bug where record rejected via find stayed in loading state
#3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`store.getById(typeClass, id)` is used inside the rejection handler of `find` to get the record and invoke the corresponding hooks. This is buggy since the record is not loaded yet into the store - a successful `find` would mark it as such - and hence the `store.getById` returned `null`. That's why the hooks are not called and the record stays in the `loading` state, having the `isLoaded` flag still being set to `false`. The fix is to reuse the `record` parameter, which is passed to the `find` method. By this, the hooks are invoked and the record is passed transitioned out of the `loading` state.
| @@ -29,13 +29,11 @@ export function _find(adapter, store, typeClass, id, record) { | |||
| return store.push(typeClass, payload); | |||
| }); | |||
| }, function(error) { | |||
| var record = store.getById(typeClass, id); | |||
There was a problem hiding this comment.
|
Thanks! |
igorT
added a commit
that referenced
this pull request
May 5, 2015
…find_request Fix bug where record rejected via `find` stayed in loading state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store.getById(typeClass, id)is used inside the rejection handler offindto get the record and invoke the corresponding hooks. This isbuggy since the record is not loaded yet into the store - a successful
findwould mark it as such - and hence thestore.getByIdreturnednull. That's why the hooks are not called and the record stays in theloadingstate, having theisLoadedflag still being set tofalse.The fix is to reuse the
recordparameter, which is passed to thefindmethod. By this, the hooks are invoked and the record is passedtransitioned out of the
loadingstate.This partially addresses #3013