A new record which is marked as invalid can be rollbacked #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously rolling back a new record which has been marked as invalid by the adapter left the record in the `loaded.created.uncommitted` state.
| @@ -399,6 +399,9 @@ var createdState = dirtyState({ | |||
| isNew: true | |||
| }); | |||
|
|
|||
| createdState.invalid.rolledBack = function(record) { | |||
There was a problem hiding this comment.
This is much better solution then my last commit. I was trying to handle it same way but within createdState.invalid.rolleback which is of course wrong. +1
|
+1 |
|
+1 I think it is good to merge @igorT |
igorT
added a commit
that referenced
this pull request
Jun 2, 2015
…backed A new record which is marked as invalid can be rollbacked
|
Thanks! |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously rolling back a new record which has been marked as invalid by
the adapter left the record in the
loaded.created.uncommittedstate.This addresses the issues raised in #2943 (comment):