Ensure snapshot.belongsTo() and hasMany() do not return deleted records #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though we remove records from their opposite relationships once they are deleted, this commit places this functionality under test and ensures that only non deleted records are returned from snapshot.belongsTo() and snapshot.hasMany(). Closes emberjs#3081
|
@igorT said we may want to ensure this functionality even though tests pass without the implementation in the snapshot package. At the very least, we do want the test coverage I believe. |
| @@ -246,7 +262,7 @@ test("snapshot.belongsTo() and snapshot.hasMany() returns correctly when setting | |||
| }); | |||
| }); | |||
|
|
|||
| test("snapshot.hasMany() returns ID if option.id is set", function() { | |||
| test("snapshot.belongsTo() returns ID if option.id is set", function() { | |||
There was a problem hiding this comment.
Test was incorrectly named
igorT
added a commit
that referenced
this pull request
Jun 3, 2015
…eted-records Ensure snapshot.belongsTo() and hasMany() do not return deleted records
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we remove records from their opposite relationships once they are deleted, this commit places this functionality under test and ensures that only non deleted records are returned from snapshot.belongsTo() and snapshot.hasMany().
Closes #3081