Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the jsbin link so it has no deprecation warnings #3390

Merged
merged 1 commit into from
Oct 12, 2015
Merged

Update the jsbin link so it has no deprecation warnings #3390

merged 1 commit into from
Oct 12, 2015

Conversation

bmac
Copy link
Member

@bmac bmac commented Jun 18, 2015

No description provided.

@wecc
Copy link
Contributor

wecc commented Jun 20, 2015

Do we want to promote the JSONAPIAdapter instead of RESTAdapter?

@igorT
Copy link
Member

igorT commented Jun 27, 2015

Can you set the html,js flags, as css is not needed

@bmac
Copy link
Member Author

bmac commented Jul 17, 2015

@wecc @igorT I have updated this pr to exclude the css page on the jsbin and added a link for the JSONAPIAdapter example.

@wecc
Copy link
Contributor

wecc commented Jul 18, 2015

@bmac really nice! getting a deprecation for shouldReloadAll in the JSONAPIAdapter one

@bmac
Copy link
Member Author

bmac commented Oct 12, 2015

Thanks @wecc the deprecation warning have been fixed.

bmac added a commit that referenced this pull request Oct 12, 2015
@bmac
Merge pull request #3390 from bmac/update-jsbin
9f4ec7c 
Update the jsbin link so it has no deprecation warnings
@bmac bmac merged commit 9f4ec7c into emberjs:master Oct 12, 2015
@bmac bmac deleted the update-jsbin branch October 12, 2015 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmac @wecc @igorT