Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMS modelNameFromPayloadKey and serializePolymorphicType cleanup #3392

Merged
merged 1 commit into from
Jun 19, 2015
Merged

AMS modelNameFromPayloadKey and serializePolymorphicType cleanup #3392

merged 1 commit into from
Jun 19, 2015

Conversation

artych
Copy link

@artych artych commented Jun 19, 2015

This is planned cleanup due to Ember.String functions now works properly with namespaced modelNames, see emberjs/ember.js#10980

@wecc
Copy link
Contributor

wecc commented Jun 19, 2015

LGTM. Would you be able to provide this to https://github.com/ember-data/active-model-adapter too?

@artych
Copy link
Author

artych commented Jun 19, 2015

@wecc , sure

wecc added a commit that referenced this pull request Jun 19, 2015
AMS modelNameFromPayloadKey and serializePolymorphicType cleanup
@wecc wecc merged commit cafddd1 into emberjs:master Jun 19, 2015
@wecc
Copy link
Contributor

wecc commented Jun 19, 2015

Thanks!

@artych
Copy link
Author

artych commented Jun 19, 2015

@wecc , cc @fivetanley
I've just tried to post PR on ember-data/active-model-adapter repo, but this commit fails test, because it needs following dependencies:

  • "ember-inflector": "^1.6.2", (includes commit that fixes singuralize/pluralize for namespace modelNames)
  • "ember":"^1.13.0", (includes commit that fixes capitalize/camelize/dasherize/undercore for namespaced modelNames)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants