Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Fill @property of DS.Model.modelName #3473

Merged
merged 1 commit into from
Jul 1, 2015
Merged

[DOC] Fill @property of DS.Model.modelName #3473

merged 1 commit into from
Jul 1, 2015

Conversation

XrXr
Copy link
Contributor

@XrXr XrXr commented Jul 1, 2015

Before this commit, the property would should up as not having a name
in the docs.

invisible property

@bmac
Copy link
Member

bmac commented Jul 1, 2015

Awesome thanks @XrXr. I just notice this too #3472.

Do you mind amending the commit message to start with [DOC release] so we can make sure this is fixed in the 1.13 branch?

@bmac bmac mentioned this pull request Jul 1, 2015
Closed
@XrXr
[DOC release] Fill @Property of DS.Model.modelName
334ce73 
Before this commit, the property would should up as not having a name
in the docs.
@XrXr
Copy link
Contributor Author

XrXr commented Jul 1, 2015

@bmac amended :)

bmac added a commit that referenced this pull request Jul 1, 2015
@bmac
Merge pull request #3473 from XrXr/doc-invisible-property
bfeeb90 
[DOC] Fill @Property of DS.Model.modelName
@bmac bmac merged commit bfeeb90 into emberjs:master Jul 1, 2015
@bmac
Copy link
Member

bmac commented Jul 1, 2015

Thanks

@XrXr XrXr deleted the doc-invisible-property branch July 1, 2015 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XrXr @bmac