Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert filter by #3648

Merged
merged 2 commits into from
Aug 13, 2015
Merged

Revert filter by #3648

merged 2 commits into from
Aug 13, 2015

Conversation

bmac
Copy link
Member

@bmac bmac commented Aug 13, 2015

This pr reverts #3263 on Ember 1.13. Which caused regressions in existing apps using RecordArray#filterBy

@bmac
Revert "Implement filterBy on DS.ManyArray"
8f8d0f7 
This reverts commit 2f1b542.
@bmac
Revert "Add RecordArray#filterBy which contains a live, filtered su…
99618e4 
…bset"

This reverts commit dc0c444.

Conflicts:
	packages/ember-data/tests/unit/record-array-test.js
bmac added a commit that referenced this pull request Aug 13, 2015
@bmac
Merge pull request #3648 from bmac/revert-filter-by
0566a99 
Revert filter by
@bmac bmac merged commit 0566a99 into emberjs:release Aug 13, 2015
@bmac bmac deleted the revert-filter-by branch August 13, 2015 16:04
@wecc wecc mentioned this pull request Oct 22, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bmac