Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release-1-13] Disable polymorphic deserialization when a mode… #3725

Merged
merged 1 commit into from
Sep 10, 2015
Merged

[BUGFIX release-1-13] Disable polymorphic deserialization when a mode… #3725

merged 1 commit into from
Sep 10, 2015

Commits on Sep 3, 2015

  1. [BUGFIX release-1-13] Disable polymorphic deserialization when a mode… 

    …l expects a type attribute

b7f7b7a introduced a bug where if there is a type key in a payload that is part
of an array, it would be used for polymorphic deserialization even when the
model expects an attribute that is named "type".

Interestingly, for such payloads, `arrayHash` passed into `normalizeArray()` in
rest-serializer.js contains Ember.Object instances as opposed to plain objects.
This causes the code to throw, since `hash.type` would be a computed property
in that case. This is probably because of extending from JSONAPISerializer.
    Alan committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    a117f01 View commit details
    Browse the repository at this point in the history