[BUGFIX beta] Fix Model id handling, take 2
#3744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acburdine
force-pushed
the
id-fix-foreal
branch
2 times, most recently
from
98fab8a
to
8c0803b
Compare
acburdine
force-pushed
the
id-fix-foreal
branch
from
8c0803b
to
4de73a5
Compare
| }, | ||
|
|
||
| // handlers for the id property | ||
| unknownProperty: function (key) { |
There was a problem hiding this comment.
I think this way requires uses to do record.get('id') to access the id. I was hoping to support record.id because it previously worked before the internal model refactor but maybe thats not possible :(.
There was a problem hiding this comment.
Well, this unknown property only needs to be in place until ember 2.2, as I think the object.defineProperty way should work then via rwjblue's fix
|
@bmac if I add an observer to the |
|
Superseded by #3781. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the thing that should have been fixed in #3701