Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC beta] Update Object Root docs re: plurals #3749

Merged
merged 1 commit into from
Sep 11, 2015
Merged

[DOC beta] Update Object Root docs re: plurals #3749

merged 1 commit into from
Sep 11, 2015

Conversation

elithrar
Copy link
Contributor

This partially addresses some of the documentation requirements in emberjs/ember.js#12319

Specifically:

  • Clarification that root keys can be pluralized regardless—Ember not being strict about this may help others understand whether they need to normalize a response.
  • A further note that—if a HTTP server responds to a findRecord request for a specific ID (or other param) with more than one object in the array—Ember Data will only parse the object with the matching ID/param.

This is low hanging fruit but I wanted to test the appetite for small doc changes like this—I suspect I'll have a few as I work through some Go + Ember stuff!

@wecc
Copy link
Contributor

wecc commented Sep 10, 2015

There are a couple of code style errors (trailing whitespace) causing Travis to fail. Could you correct them?

- Pluralizing object roots is not explicitly required.
- Clarified that Ember Data will match on ID even if there's more than one result in a response to findRecord
@elithrar
Copy link
Contributor Author

@wecc - done. Last time I use the GitHub markdown editor for a quick fix ;)

wecc added a commit that referenced this pull request Sep 11, 2015
[DOC beta] Update Object Root docs re: plurals
@wecc wecc merged commit 5e14d74 into emberjs:master Sep 11, 2015
@wecc
Copy link
Contributor

wecc commented Sep 11, 2015

Thanks @elithrar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants