[BUGFIX beta] Correctly handle invalid errors without payload or pointer #3859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -644,6 +646,10 @@ InternalModel.prototype = { | |||
| } | |||
| } | |||
|
|
|||
| if (isEmpty(Object.keys(errors))) { | |||
| this.send('becameInvalid'); | |||
| } | |||
There was a problem hiding this comment.
Why not always send the becameInvalid event?
There was a problem hiding this comment.
because it will double send it (because of events on errors) and it breaks lots of tests
There was a problem hiding this comment.
What happens if this code runs to put the record in the invalid state then an error is added to the errors object?
|
@tchak could you amend this commit to start with |
tchak
force-pushed
the
handle-invlid-errors-without-payload
branch
2 times, most recently
from
51acce0
to
100390b
Compare
tchak
changed the title
tchak
force-pushed
the
handle-invlid-errors-without-payload
branch
from
100390b
to
f4e7100
Compare
|
@bmac so after some thought it probably make sens to be able to call |
|
Looks good. 👍 |
tchak
added a commit
that referenced
this pull request
Oct 15, 2015
[BUGFIX beta] Correctly handle invalid errors without payload or pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3851, #3852