Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Clean up adapter/find-all-test.js #3925

Merged
merged 1 commit into from
Nov 14, 2015
Merged

[CLEANUP] Clean up adapter/find-all-test.js #3925

merged 1 commit into from
Nov 14, 2015

Conversation

seanpdoyle
Copy link
Contributor

  • Use ES6 () => where applicable
  • Remove unnecessary Ember. and Ember.RSVP prefixes
  • Remove ignored closure parameters
  • One-line adapater overrides when possible

@seanpdoyle
[CLEANUP] Clean up adapter/find-all-test.js
df81e19 
* Use ES6 `() =>` where applicable
* Remove unnecessary `Ember.` and `Ember.RSVP` prefixes
* Remove ignored closure parameters
* One-line adapater overrides when possible
@fivetanley
Copy link
Member

yassssss thank you

fivetanley added a commit that referenced this pull request Nov 14, 2015
@fivetanley
Merge pull request #3925 from seanpdoyle/sd-cleanup-adapter-tests
80f582d 
[CLEANUP] Clean up adapter/find-all-test.js
@fivetanley fivetanley merged commit 80f582d into emberjs:master Nov 14, 2015
@seanpdoyle seanpdoyle deleted the sd-cleanup-adapter-tests branch November 14, 2015 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanpdoyle @fivetanley