Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the date import to where it is used intead of the root module #4082

Merged
merged 1 commit into from
Jan 18, 2016

Conversation

bmac
Copy link
Member

@bmac bmac commented Jan 15, 2016

No description provided.

@pangratz
Copy link
Member

I wonder if Ember.Date should be removed as a whole an only the parse part should be imported? Ember.Date shows up in the API doc, but it only has the parse function, and doesn't extend JS Date.

I am not sure what the correct way would be though, semver-wise. Maybe deprecate it for 3.0?

@rwjblue
Copy link
Member

rwjblue commented Jan 15, 2016

We can provide a public module for date parsing, I know some users rely on Ember.Date.parse existing...

@bmac
Copy link
Member Author

bmac commented Jan 18, 2016

I opened an issue to track the Date.parse comments outside of this pr.

bmac added a commit that referenced this pull request Jan 18, 2016
Move the date import to where it is used intead of the root module
@bmac bmac merged commit c87717b into emberjs:master Jan 18, 2016
@pangratz
Copy link
Member

I opened an issue to track the Date.parse comments outside of this pr.

👍

@bmac bmac deleted the move-date-import branch January 18, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants